From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Andreas Färber" <andreas.faerber@web.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] darwin-user: Fix format string in debug message
Date: Tue, 22 Nov 2011 10:57:16 +0000 [thread overview]
Message-ID: <CAFEAcA9LHoQRXi2vFmr_bMUEsCU4vqLa7zurw5HFWnTAsjp_rw@mail.gmail.com> (raw)
In-Reply-To: <20111122104354.GA27846@stefanha-thinkpad.localdomain>
On 22 November 2011 10:43, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Nov 19, 2011 at 08:18:39PM +0100, Stefan Weil wrote:
>> This was spotted by cppcheck.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> darwin-user/signal.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> I am waiting to see if you send a v2 or this thread continues. Not
> applied to trivial-patches.
FWIW I think the patch as it is is fine. We have already printed
sa_handler &c in the immediately preceding line of debug output so
there's nothing gained from printing them again; probably it was
a stray cut-n-paste error in the first place.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
next prev parent reply other threads:[~2011-11-22 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 19:18 [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message Stefan Weil
2011-11-21 13:32 ` Andreas Färber
2011-11-21 13:41 ` Peter Maydell
2011-11-22 10:43 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-11-22 10:57 ` Peter Maydell [this message]
2011-11-22 11:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9LHoQRXi2vFmr_bMUEsCU4vqLa7zurw5HFWnTAsjp_rw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).