From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSo2W-0001zu-1C for qemu-devel@nongnu.org; Tue, 22 Nov 2011 05:57:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSo2Q-0007cT-7g for qemu-devel@nongnu.org; Tue, 22 Nov 2011 05:57:24 -0500 MIME-Version: 1.0 In-Reply-To: <20111122104354.GA27846@stefanha-thinkpad.localdomain> References: <1321730319-21498-1-git-send-email-sw@weilnetz.de> <20111122104354.GA27846@stefanha-thinkpad.localdomain> Date: Tue, 22 Nov 2011 10:57:16 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] darwin-user: Fix format string in debug message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, Stefan Weil , =?UTF-8?Q?Andreas_F=C3=A4rber?= , qemu-devel@nongnu.org On 22 November 2011 10:43, Stefan Hajnoczi wrote: > On Sat, Nov 19, 2011 at 08:18:39PM +0100, Stefan Weil wrote: >> This was spotted by cppcheck. >> >> Signed-off-by: Stefan Weil >> --- >> =C2=A0darwin-user/signal.c | =C2=A0 =C2=A03 +-- >> =C2=A01 files changed, 1 insertions(+), 2 deletions(-) > > I am waiting to see if you send a v2 or this thread continues. =C2=A0Not > applied to trivial-patches. FWIW I think the patch as it is is fine. We have already printed sa_handler &c in the immediately preceding line of debug output so there's nothing gained from printing them again; probably it was a stray cut-n-paste error in the first place. Reviewed-by: Peter Maydell -- PMM