qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: "Edgar Iglesias" <edgar.iglesias@xilinx.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Sai Pavan Boddu" <saipava@xilinx.com>,
	"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
	"John Snow" <jsnow@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP
Date: Tue, 8 Sep 2015 15:57:29 +0100	[thread overview]
Message-ID: <CAFEAcA9M2hb8VEeT_mwLSYKx7Yz4-huuSBGHEZp_4Bk3A4kdSg@mail.gmail.com> (raw)
In-Reply-To: <6e0045ed58a395ec0e3caa1c1abf478b41e5023b.1440806502.git.alistair.francis@xilinx.com>

On 29 August 2015 at 01:04, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Connect the Sysbus AHCI device to ZynqMP.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Sai Pavan Boddu <saipava@xilinx.com>

> +    object_property_set_int(OBJECT(&s->sata), SATA_NUM_PORTS, "num-ports",
> +                            &error_abort);
> +    object_property_set_bool(OBJECT(&s->sata), true, "realized", &err);
> +    if (err) {
> +        error_propagate((errp), (err));

Weird unnecessary extra brackets. I'll just remove them...

-- PMM

  parent reply	other threads:[~2015-09-08 14:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-29  0:04 [Qemu-devel] [PATCH v6 0/4] xlnx-zynqmp: Connect the AHCI SATA device Alistair Francis
2015-08-29  0:04 ` [Qemu-devel] [PATCH v6 1/4] ahci: Separate the AHCI state structure into the header Alistair Francis
2015-08-29  0:04 ` [Qemu-devel] [PATCH v6 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState Alistair Francis
2015-08-31 22:38   ` John Snow
2015-09-01  0:59     ` Alistair Francis
2015-09-04 19:48   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-08-29  0:04 ` [Qemu-devel] [PATCH v6 3/4] xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_abort Alistair Francis
     [not found] ` <6e0045ed58a395ec0e3caa1c1abf478b41e5023b.1440806502.git.alistair.francis@xilinx.com>
2015-08-31 20:54   ` [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP John Snow
2015-08-31 21:28     ` Alistair Francis
2015-09-04 13:42       ` Peter Maydell
2015-09-04 15:19         ` Alistair Francis
2015-09-04 19:59         ` John Snow
2015-09-04 23:46           ` Alistair Francis
2015-09-04 19:51   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-09-08 14:57   ` Peter Maydell [this message]
2015-09-08 19:35     ` [Qemu-devel] [PATCH " Alistair Francis
2015-09-08 15:00 ` [Qemu-devel] [PATCH RESEND v6 0/4] xlnx-zynqmp: Connect the AHCI SATA device Peter Maydell
2015-09-09  0:08   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9M2hb8VEeT_mwLSYKx7Yz4-huuSBGHEZp_4Bk3A4kdSg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).