From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Patch Tracking <patches@linaro.org>,
Alexander Graf <agraf@suse.de>,
Markus Armbruster <armbru@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives
Date: Tue, 9 Jun 2015 19:23:18 +0100 [thread overview]
Message-ID: <CAFEAcA9M9oBU=gUOYGuNvfdVDkpA9N__o4uUX0k8-KcuujCuyQ@mail.gmail.com> (raw)
In-Reply-To: <1433872103-30642-1-git-send-email-peter.maydell@linaro.org>
On 9 June 2015 at 18:48, Peter Maydell <peter.maydell@linaro.org> wrote:
> Patch 3 is the one-liner to change the default-drive-type. Unfortunately
> just doing that alone will break commandlines that currently work
The other problem with taking patch 3 alone is that it completely
breaks everything, because:
* by default we create a "cdrom" drive whose type is <board-default>
and which has no media inserted
* the virtio-blk device barfs if you give it a drive with no media:
"Device needs media, but drive is empty"
The S390 systems get around this by specifying no_cdrom = 1, but
it doesn't seem terribly satisfactory that this has to be manually
done by any machine with a virtio default drive type...
-- PMM
next prev parent reply other threads:[~2015-06-09 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 17:48 [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives Peter Maydell
2015-06-09 17:48 ` [Qemu-devel] [PATCH v2 1/3] blockdev: Factor out create_implicit_virtio_device Peter Maydell
2015-06-09 17:48 ` [Qemu-devel] [PATCH v2 2/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives Peter Maydell
2015-06-09 17:48 ` [Qemu-devel] [PATCH v2 3/3] hw/arm/virt: Make block devices default to virtio Peter Maydell
2015-06-09 18:23 ` Peter Maydell [this message]
2015-06-20 15:09 ` [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives Markus Armbruster
2015-06-09 19:16 ` Peter Maydell
2015-06-20 15:37 ` Markus Armbruster
2015-06-20 15:00 ` Markus Armbruster
2015-06-20 15:27 ` Peter Maydell
2015-06-20 16:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9M9oBU=gUOYGuNvfdVDkpA9N__o4uUX0k8-KcuujCuyQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).