From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2OIJ-0000bF-MK for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:30:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2OIG-0004wL-GV for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:30:39 -0400 Received: from mail-vn0-f48.google.com ([209.85.216.48]:42708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2OIG-0004vz-DH for qemu-devel@nongnu.org; Tue, 09 Jun 2015 14:30:36 -0400 Received: by vnbg129 with SMTP id g129so4104312vnb.9 for ; Tue, 09 Jun 2015 11:30:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1433872103-30642-1-git-send-email-peter.maydell@linaro.org> References: <1433872103-30642-1-git-send-email-peter.maydell@linaro.org> From: Peter Maydell Date: Tue, 9 Jun 2015 19:23:18 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Kevin Wolf , qemu-block@nongnu.org, Patch Tracking , Alexander Graf , Markus Armbruster , Christian Borntraeger , Cornelia Huck On 9 June 2015 at 18:48, Peter Maydell wrote: > Patch 3 is the one-liner to change the default-drive-type. Unfortunately > just doing that alone will break commandlines that currently work The other problem with taking patch 3 alone is that it completely breaks everything, because: * by default we create a "cdrom" drive whose type is and which has no media inserted * the virtio-blk device barfs if you give it a drive with no media: "Device needs media, but drive is empty" The S390 systems get around this by specifying no_cdrom = 1, but it doesn't seem terribly satisfactory that this has to be manually done by any machine with a virtio default drive type... -- PMM