qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Alistair Francis <alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH] null-machine: Add support for the "-kernel" parameter
Date: Mon, 27 Feb 2017 18:00:58 +0000	[thread overview]
Message-ID: <CAFEAcA9N6RUs0LjSLxf9isOKZqSwB=t670Ax33osY+V3Ajj8xw@mail.gmail.com> (raw)
In-Reply-To: <6e297b78-dab8-93c5-2a86-1ec267d65eb3@redhat.com>

On 27 February 2017 at 17:57, Thomas Huth <thuth@redhat.com> wrote:
> And I still think it does not really make sense to introduce a
> per-architecture hook here - let me cite my reply to Peter's mail a
> couple of mails later in that e-mail thread:
>
> 'The -kernel parameter is not just only dependent on the target
> architecture, it is even dependent on the machine type, e.g. on ppc it
> is quite different between embedded (e500.c) and server (spapr.c)
> variants. So an arch-specific hook might not make too much sense and
> using the generic loader is likely the best we can do - if that does not
> work, you likely can't use the "none" machine anyway.'
>
> So as far as I can see, we should either go with the generic loader
> here, or print out an error message if the user tries to run QEMU with
> the "-kernel" parameter.

I would go for "don't support -kernel". The fundamental problem
with -kernel is that it tries to be a magic "do what I mean"
command line argument. Adding extra magic is going to make things
worse, not better.

thanks
-- PMM

  reply	other threads:[~2017-02-27 18:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  8:40 [Qemu-devel] [PATCH] null-machine: Add support for the "-kernel" parameter Thomas Huth
2017-01-25 14:42 ` Laurent Vivier
2017-01-25 16:04   ` Thomas Huth
2017-02-27 11:43 ` Thomas Huth
2017-02-27 13:16   ` Marcel Apfelbaum
2017-02-27 17:49     ` Thomas Huth
2017-02-27 17:53       ` Peter Maydell
2017-02-27 14:00   ` Eduardo Habkost
2017-02-27 17:57     ` Thomas Huth
2017-02-27 18:00       ` Peter Maydell [this message]
2017-02-27 18:10         ` Thomas Huth
2017-02-27 19:06           ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9N6RUs0LjSLxf9isOKZqSwB=t670Ax33osY+V3Ajj8xw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alistair.francis@xilinx.com \
    --cc=ehabkost@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=laurent@vivier.eu \
    --cc=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).