From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"Thomas Huth" <huth@tuxfamily.org>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller
Date: Mon, 9 Sep 2019 17:11:53 +0100 [thread overview]
Message-ID: <CAFEAcA9NiHrGekrEte7__aGKSz-JBObdbWdMxmxduYozngDUNQ@mail.gmail.com> (raw)
In-Reply-To: <20190909155813.27760-9-laurent@vivier.eu>
On Mon, 9 Sep 2019 at 17:05, Laurent Vivier <laurent@vivier.eu> wrote:
>
> Co-developed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
> +static void sysbus_swim_class_init(ObjectClass *oc, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(oc);
> +
> + dc->realize = sysbus_swim_realize;
> +}
Missing reset and VMState for migration. These should be
baseline requirements for adding new device models to the
tree, because in an ideal world every device would support
both -- we should be gradually fixing the existing devices
which are missing these, and not letting new devices in,
so the situation gets gradually better, not worse.
thanks
-- PMM
next prev parent reply other threads:[~2019-09-09 16:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:58 [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 1/9] esp: add pseudo-DMA as used by Macintosh Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 2/9] dp8393x: manage big endian bus Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 3/9] hw/m68k: add via support Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 4/9] hw/m68k: implement ADB bus support for via Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 5/9] hw/m68k: add macfb video card Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 6/9] hw/m68k: add Nubus support Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 7/9] hw/m68k: add Nubus support for macfb video card Laurent Vivier
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller Laurent Vivier
2019-09-09 16:11 ` Peter Maydell [this message]
2019-09-09 16:18 ` Dr. David Alan Gilbert
2019-09-09 16:21 ` Peter Maydell
2019-09-09 16:34 ` Laurent Vivier
2019-09-09 18:21 ` Laurent Vivier
2019-09-09 16:32 ` Aleksandar Markovic
2019-09-09 16:44 ` Laurent Vivier
2019-09-09 17:41 ` Aleksandar Markovic
2019-09-09 15:58 ` [Qemu-devel] [PATCH v9 9/9] hw/m68k: define Macintosh Quadra 800 Laurent Vivier
2019-09-09 16:59 ` [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine no-reply
2019-09-09 17:10 ` no-reply
2019-09-09 18:07 ` no-reply
2019-09-09 20:06 ` no-reply
2019-09-09 20:55 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9NiHrGekrEte7__aGKSz-JBObdbWdMxmxduYozngDUNQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).