qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, marcandre.lureau@redhat.com,
	richard.henderson@linaro.org
Subject: Re: [PATCH v2 0/6] meson: use subprojects for bundled projects
Date: Fri, 19 May 2023 10:38:19 +0100	[thread overview]
Message-ID: <CAFEAcA9P-mAQ-Vf8vs=jsFpcKePnnFFtaP11_RAjZNhmmzOUKw@mail.gmail.com> (raw)
In-Reply-To: <ZGdCL3Ka2JSeo+XD@redhat.com>

On Fri, 19 May 2023 at 10:32, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, May 19, 2023 at 10:21:03AM +0100, Peter Maydell wrote:
> > On Fri, 19 May 2023 at 09:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > QEMU bundles a copy of dtc and keycodemapdb.  They both support meson,
> > > so we can run their build system via subproject() instead of hardcoding
> > > their contents.
> > >
> > > In fact, now that QEMU's configure script knows how to install missing
> > > Python dependencies, we can replace submodules altogether with .wrap
> > > files, which have several advantages, either immediate or potential:
> >
> > So do we have a path for getting rid of submodules entirely?
> > I'd be all in favour of that, but I'm somewhat less in favour
> > of "some things are submodules and some things are this new
> > .wrap file setup"...
>
> I think we can ignore 'roms' submodules on the basis they are never used
> during a normal build, they're mostly just a maintainer convenience and
> for release archive source bundling.

Yeah, I agree -- or at least I agree they're a distinct use of
submodules. We might at some point want to look at whether there's
a better way to deal with ROM blobs than what we do today, especially
as the size of the source archives for things like UEFI is much
bigger than I expect anybody anticipated when they set the rom
blob machinery up. I don't think the way we do ROM blobs is
very convenient for our distro downstreams either.

-- PMM


  reply	other threads:[~2023-05-19  9:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19  8:56 [PATCH v2 0/6] meson: use subprojects for bundled projects Paolo Bonzini
2023-05-19  8:56 ` [PATCH 1/6] remove remaining traces of meson submodule Paolo Bonzini
2023-05-19  9:02   ` Daniel P. Berrangé
2023-05-19  8:56 ` [PATCH 2/6] meson: simplify logic for -Dfdt Paolo Bonzini
2023-05-19  9:04   ` Daniel P. Berrangé
2023-05-19  8:56 ` [PATCH 3/6] meson: use subproject for internal libfdt Paolo Bonzini
2023-05-19  9:05   ` Daniel P. Berrangé
2023-05-19  8:56 ` [PATCH 4/6] meson: use subproject for keycodemapdb Paolo Bonzini
2023-05-19  9:06   ` Daniel P. Berrangé
2023-05-19  8:56 ` [PATCH 5/6] configure: rename --enable-pypi to --enable-download, control subprojects too Paolo Bonzini
2023-05-19  9:07   ` Daniel P. Berrangé
2023-05-19  8:56 ` [PATCH 6/6] meson: subprojects: replace submodules with wrap files Paolo Bonzini
2023-05-19  9:25   ` Daniel P. Berrangé
2023-05-19  9:36     ` Paolo Bonzini
2023-05-19  9:21 ` [PATCH v2 0/6] meson: use subprojects for bundled projects Peter Maydell
2023-05-19  9:28   ` Paolo Bonzini
2023-05-19  9:32   ` Daniel P. Berrangé
2023-05-19  9:38     ` Peter Maydell [this message]
2023-05-19  9:40     ` Paolo Bonzini
2023-05-19 11:48     ` Paolo Bonzini
2023-05-24  7:51       ` Thomas Huth
2023-05-19  9:30 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9P-mAQ-Vf8vs=jsFpcKePnnFFtaP11_RAjZNhmmzOUKw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).