From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agA4k-0000ko-3l
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:57:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agA4g-0000k2-7t
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:57:18 -0400
Received: from mail-vk0-x236.google.com ([2607:f8b0:400c:c05::236]:36629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agA4f-0000jI-1r
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:57:14 -0400
Received: by mail-vk0-x236.google.com with SMTP id c3so58192294vkb.3
	for <qemu-devel@nongnu.org>; Wed, 16 Mar 2016 04:57:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1457334350-5675-5-git-send-email-zxq_yx_007@163.com>
References: <1457334350-5675-1-git-send-email-zxq_yx_007@163.com>
	<1457334350-5675-5-git-send-email-zxq_yx_007@163.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 16 Mar 2016 11:56:53 +0000
Message-ID: <CAFEAcA9QBShnRGSdkAY+gP7pMgtwaVCJ2UVPawviyfSt97W4pw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 4/9] hw/arm: QOM'ify pxa2xx.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: Rob Herring <robh@kernel.org>, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 7 March 2016 at 07:05, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> Drop the use of old SysBus init function and use instance_init
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  hw/arm/pxa2xx.c | 26 +++++++++++---------------
>  1 file changed, 11 insertions(+), 15 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Again, more cleanups are possible on these devices...

thanks
-- PMM