From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Yang Zhong <yang.zhong@intel.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build
Date: Tue, 20 Jun 2017 19:41:46 +0100 [thread overview]
Message-ID: <CAFEAcA9Ra6dvyDExJ9GaSMiNBcifdz7_FJvLKBznTyVX=ab5Mg@mail.gmail.com> (raw)
In-Reply-To: <20170620163009.21764-1-f4bug@amsat.org>
On 20 June 2017 at 17:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> fix regression from commit 244f144134:
>
> $ make subdir-arm-softmmu
> make[1]: *** No rule to make target 'tci.o', needed by 'qemu-system-arm'. Stop.
> Makefile:328: recipe for target 'subdir-arm-softmmu' failed
> make: *** [subdir-arm-softmmu] Error 2
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Makefile.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 3d49f29457..0066579090 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -92,7 +92,7 @@ obj-y += exec.o
> obj-y += accel/
> obj-y += tcg/tcg.o tcg/tcg-op.o tcg/optimize.o
> obj-y += tcg/tcg-common.o tcg/tcg-runtime.o
> -obj-$(CONFIG_TCG_INTERPRETER) += tci.o
> +obj-$(CONFIG_TCG_INTERPRETER) += tcg/tci.o
> obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o
> obj-y += fpu/softfloat.o
> obj-y += target/$(TARGET_BASE_ARCH)/
> --
> 2.11.0
Applied to master as a buildfix; thanks.
(I should probably put a tcg-interpreter build in my local build tests,
but I'd prefer we just got rid of it.)
-- PMM
prev parent reply other threads:[~2017-06-20 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 16:30 [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build Philippe Mathieu-Daudé
2017-06-20 17:17 ` no-reply
2017-06-20 17:36 ` Philippe Mathieu-Daudé
2017-06-20 18:41 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9Ra6dvyDExJ9GaSMiNBcifdz7_FJvLKBznTyVX=ab5Mg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).