From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bFRdA-0004n1-6t
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 15:46:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bFRd8-0002la-FD
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 15:46:39 -0400
Received: from mail-vk0-x233.google.com ([2607:f8b0:400c:c05::233]:33957)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bFRd8-0002lT-B4
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 15:46:38 -0400
Received: by mail-vk0-x233.google.com with SMTP id c2so4227059vkg.1
	for <qemu-devel@nongnu.org>; Tue, 21 Jun 2016 12:46:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160621182634.5xwirsgel7i4twmm@hawk.localdomain>
References: <1466528974-12183-1-git-send-email-peter.maydell@linaro.org>
	<1466528974-12183-5-git-send-email-peter.maydell@linaro.org>
	<20160621182634.5xwirsgel7i4twmm@hawk.localdomain>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 21 Jun 2016 20:46:18 +0100
Message-ID: <CAFEAcA9SLKxKJD3VRYYb5hXPpZ2BvWhfPkBK0E2FwzZHm94Sow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 4/6] cpu: Support a target CPU having a
 variable page size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Patch Tracking <patches@linaro.org>

On 21 June 2016 at 19:26, Andrew Jones <drjones@redhat.com> wrote:
> On Tue, Jun 21, 2016 at 06:09:32PM +0100, Peter Maydell wrote:
>> --- a/include/qemu-common.h
>> +++ b/include/qemu-common.h
>> @@ -76,6 +76,19 @@ void tcg_exec_init(unsigned long tb_size);
>>  bool tcg_enabled(void);
>>
>>  void cpu_exec_init_all(void);
>> +void cpu_exec_machine_creation_done(void);
>
> Was the above added here by mistake?

Yes; leftover from an attempt at finalizing the page
size much later in init; I deleted the function but forgot
the prototype (and gcc doesn't warn about that).

thanks
-- PMM