qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-xtensa: raise an exception for invalid and reserved opcodes
Date: Tue, 25 Oct 2011 17:51:35 +0100	[thread overview]
Message-ID: <CAFEAcA9Scsg5kJgPRRV0n-a5uwUbgO6EYXcnbMyBPKUnYj4Shg@mail.gmail.com> (raw)
In-Reply-To: <1319561060-6472-1-git-send-email-jcmvbkbc@gmail.com>

On 25 October 2011 17:44, Max Filippov <jcmvbkbc@gmail.com> wrote:
> This includes opcodes from disabled features and those marked reserved in the ISA.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  target-xtensa/translate.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c
> index 1688bb2..792eff1 100644
> --- a/target-xtensa/translate.c
> +++ b/target-xtensa/translate.c
> @@ -2378,6 +2378,7 @@ static void disas_xtensa_insn(DisasContext *dc)
>
>  invalid_opcode:
>     qemu_log("INVALID(pc = %08x)\n", dc->pc);
> +    gen_exception_cause(dc, ILLEGAL_INSTRUCTION_CAUSE);
>     dc->pc = dc->next_pc;
>  #undef HAS_OPTION
>  }

Don't you need to do something to end the TB as well?
gen_exception_cause() doesn't seem to do it for you.

-- PMM

  reply	other threads:[~2011-10-25 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 16:44 [Qemu-devel] [PATCH] target-xtensa: raise an exception for invalid and reserved opcodes Max Filippov
2011-10-25 16:51 ` Peter Maydell [this message]
2011-10-25 17:24   ` Max Filippov
2011-10-25 17:41     ` Richard Henderson
2011-10-25 19:24       ` [Qemu-devel] [PATCH v2] " Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9Scsg5kJgPRRV0n-a5uwUbgO6EYXcnbMyBPKUnYj4Shg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).