From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf8eT-0008RL-RZ for qemu-devel@nongnu.org; Thu, 03 Jan 2019 14:27:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf8eT-0000ep-1u for qemu-devel@nongnu.org; Thu, 03 Jan 2019 14:27:33 -0500 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:41561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gf8eR-0000Oe-3l for qemu-devel@nongnu.org; Thu, 03 Jan 2019 14:27:32 -0500 Received: by mail-ot1-x343.google.com with SMTP id u16so30275003otk.8 for ; Thu, 03 Jan 2019 11:27:10 -0800 (PST) MIME-Version: 1.0 References: <20190103175113.18196-1-pbonzini@redhat.com> <20190103130406-mutt-send-email-mst@kernel.org> In-Reply-To: <20190103130406-mutt-send-email-mst@kernel.org> From: Peter Maydell Date: Thu, 3 Jan 2019 19:26:58 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] include: update Linux headers to 4.21/5.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , Cornelia Huck , QEMU Developers On Thu, 3 Jan 2019 at 18:19, Michael S. Tsirkin wrote: > > On Thu, Jan 03, 2019 at 06:51:13PM +0100, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > Note that in the past we just updated what we needed. Not if I noticed it -- our copies of the Linux headers are supposed to always be synchronized entirely from a commit of Linux upstream master. Ad-hoc cherry-picked changes can easily be accidentally undone by a later sync by somebody else. This is why we have an automatic script to do header synchronization, so we don't have to manually write and review header updates. > I'd prefer the shell script part and the new vhost_types header which > are actually reviewable to be split out to a separate patch. I agree that shell script changes should be their own patch. My view is that a header-update commit should be entirely and nothing but the automatically generated results of running scripts/update-linux-headers.sh, with a commit message that says "Generated by running update-linux-headers.sh on upstream kernel commit xxxx". Then (assuming you trust the person who did that to do what they say in the commit message they're doing) you don't need to actually review the changes in detail. Doing by-hand updates to the headers is quite a common error; I'm not sure if we can automatically catch it with checkpatch. ("Any change to include/standard-headers or linux-headers/ must be a commit that touches only files in those subdirectories and whose commit message is in a standard format", perhaps.) thanks -- PMM