From: Peter Maydell <peter.maydell@linaro.org>
To: Doug Evans <dje@google.com>
Cc: Hao Wu <wuhaotsh@google.com>, Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Avi Fishman <avi.fishman@nuvoton.com>
Subject: Re: [PATCH v2 3/3] tests/qtests: Add npcm7xx emc model test
Date: Mon, 8 Feb 2021 17:21:42 +0000 [thread overview]
Message-ID: <CAFEAcA9TcGG2GCqa7FVv2KHdHft9dqL5gGL+5BKTm088XxrytQ@mail.gmail.com> (raw)
In-Reply-To: <20210202232838.1641382-4-dje@google.com>
On Tue, 2 Feb 2021 at 23:29, Doug Evans <dje@google.com> wrote:
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Avi Fishman <avi.fishman@nuvoton.com>
> Signed-off-by: Doug Evans <dje@google.com>
> ---
> tests/qtest/meson.build | 1 +
> tests/qtest/npcm7xx_emc-test.c | 793 +++++++++++++++++++++++++++++++++
> 2 files changed, 794 insertions(+)
> create mode 100644 tests/qtest/npcm7xx_emc-test.c
I see some more middle-of-function variable declarations here,
but otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
prev parent reply other threads:[~2021-02-08 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 23:28 [PATCH v2 0/3] Add npcm7xx emc model dje--- via
2021-02-02 23:28 ` [PATCH v2 1/3] hw/net: " dje--- via
2021-02-08 17:17 ` Peter Maydell
2021-02-09 1:25 ` Doug Evans
2021-02-09 9:44 ` Peter Maydell
2021-02-02 23:28 ` [PATCH v2 2/3] hw/arm: " dje--- via
2021-02-08 17:20 ` Peter Maydell
2021-02-02 23:28 ` [PATCH v2 3/3] tests/qtests: Add npcm7xx emc model test dje--- via
2021-02-08 17:21 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9TcGG2GCqa7FVv2KHdHft9dqL5gGL+5BKTm088XxrytQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=avi.fishman@nuvoton.com \
--cc=dje@google.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).