From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576C3C433E0 for ; Mon, 8 Feb 2021 21:07:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DABE664E45 for ; Mon, 8 Feb 2021 21:07:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DABE664E45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Dks-0001at-Nd for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 16:07:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9AEX-0000MT-Vs for qemu-devel@nongnu.org; Mon, 08 Feb 2021 12:21:58 -0500 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:37354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9AEV-0000Kg-DK for qemu-devel@nongnu.org; Mon, 08 Feb 2021 12:21:57 -0500 Received: by mail-ej1-x630.google.com with SMTP id jj19so26168810ejc.4 for ; Mon, 08 Feb 2021 09:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FSIPjGSh9GFEfNi2norBGtnk5ZpSgj51G+THylcaW4I=; b=fld2WnWMBohLkw7Rh9AWagJac9Fo7oWC76xgobHm1szt0TtzSxRDEhtNJxpF9lwxnG YWXswBljBAsUKl04osz9OSC5yvaC8Z66tgz5M7/hRtmbpcEKrJAdIdmLveKK61WUc1Yu A3/UokkDTRQF30QeoOxV9U8VVzn8MfwIKBeL26SPG38Aapqy8o1DPk8dXFidzPR+ChMB 93fJZ001Q6kUVDSBLsIy1SojXvbKQLia+YX+JAZgzvkVV0qzXHp2WNYVo8cse3LJAKY2 0a1uFMn+MulzcfDA7fy7ZARhCHev1Y2hoMdTP9/0uA+HVo/6c8DoVSTXVHaRaCoXA9NP fmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FSIPjGSh9GFEfNi2norBGtnk5ZpSgj51G+THylcaW4I=; b=soZLDBWivi4wdtUoKZzbcEzBO70uoaYoEHJzkqnDcPiLtSlD67OyU8tHdLrewTlhDF yOuwdFUt+bamZroeByFEojV3NzWzaC5gyeQMYdaOc2m5wFm7A/4L12Y7ar13COgW8uLw yxgWaqLrml9eZGKQ39rXS4ZSzKNO+Vgxk6dhdVAu4lomScohI1PKYcmjZRoReJj0eBXX IDMcEgN7g9mlASu37SFfDRm69lxMmj2UKohhzSRJ63GaYgrtTItlfmA0zi38rVqr8UN9 1kZZSVwuDWbNxOWMfO0UmAmQ3RBjParx2OqYXzHJzhvBCaZGJl2m1FBSwtZL1FsfM9CZ 92Kg== X-Gm-Message-State: AOAM530J6G6pNacSLMLO0oTcds0iuRCGlMRIt09pIUpCn6AcWNkOatPe hxNwgyc6ZX+YqgYkWyovzO8B1c2nln4QSQo2OF3shA/5EFE= X-Google-Smtp-Source: ABdhPJx4LGYaagJUR58+mz4iYUWHSNyv23tNh9OgchalHszP+2OJHGe/hdE6UAAjCTB6+taBQ/tCpQhI3uVwh9OrdRY= X-Received: by 2002:a17:906:184e:: with SMTP id w14mr9333988eje.56.1612804913692; Mon, 08 Feb 2021 09:21:53 -0800 (PST) MIME-Version: 1.0 References: <20210202232838.1641382-1-dje@google.com> <20210202232838.1641382-4-dje@google.com> In-Reply-To: <20210202232838.1641382-4-dje@google.com> From: Peter Maydell Date: Mon, 8 Feb 2021 17:21:42 +0000 Message-ID: Subject: Re: [PATCH v2 3/3] tests/qtests: Add npcm7xx emc model test To: Doug Evans Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hao Wu , Jason Wang , QEMU Developers , Avi Fishman Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2 Feb 2021 at 23:29, Doug Evans wrote: > > Reviewed-by: Hao Wu > Reviewed-by: Avi Fishman > Signed-off-by: Doug Evans > --- > tests/qtest/meson.build | 1 + > tests/qtest/npcm7xx_emc-test.c | 793 +++++++++++++++++++++++++++++++++ > 2 files changed, 794 insertions(+) > create mode 100644 tests/qtest/npcm7xx_emc-test.c I see some more middle-of-function variable declarations here, but otherwise Reviewed-by: Peter Maydell thanks -- PMM