From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E8EC04E30 for ; Mon, 9 Dec 2019 17:59:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70C65208C3 for ; Mon, 9 Dec 2019 17:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gMxvqQ7/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C65208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNJz-000886-9Q for qemu-devel@archiver.kernel.org; Mon, 09 Dec 2019 12:59:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56860) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNHT-0004zw-Q6 for qemu-devel@nongnu.org; Mon, 09 Dec 2019 12:57:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieNHS-0004mz-OG for qemu-devel@nongnu.org; Mon, 09 Dec 2019 12:57:11 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:43846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieNHS-0004mc-IF for qemu-devel@nongnu.org; Mon, 09 Dec 2019 12:57:10 -0500 Received: by mail-oi1-x244.google.com with SMTP id x14so7112276oic.10 for ; Mon, 09 Dec 2019 09:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lKXlVuxkWEUUPeb9LOuGSqHW5akNYDaoRPQweqBFnWY=; b=gMxvqQ7/qVHRP74un03Z7LiyW5Qm537Q8uHZXNdLncuU0rKXpbwkrP9eTXnjM1OoXZ xOBFyoKib8Livc4EeHHWk0wjCIColNqllox4jXgJKyitvw0N3RCssBpN60DWDb0litpY vg/sLkctapRcIzyjA5wB8TdDbQZS+kNgIdRK3q1VQrjdmfk0eeWLjgPo2n9Q7wqIdMxf xuYm0EG+iazbz6Oa37qiu3VFye7F7EEDw6bfnISEOK+X3iH9/mVbYdWyxomz8Q/i1iOB p5Dq61PphPABufgdqKWa1GLvhZZCRiumG2q424BLBmToimw2VhboogsaHy8ZJXdkNe4Q ObVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lKXlVuxkWEUUPeb9LOuGSqHW5akNYDaoRPQweqBFnWY=; b=BNj+j5VOQKd69fWFjCqdjdQEXRrpSpBJY+2RivCXnv7GAOYNj8tja6/2A5V3Lc2H1u 5A05c+/VZf6ELMgLNAeE/mlQy3gjwtxYuRtExaLhV8eAItoTkE+2xUc7nehzEZKJO+tR NTQbUX5j98QOCh28jrePcarYt5A6qopr92wtieRp8ZzPWDQO3NuWBW9LOktwSRHJBpu5 dRswYrGF9VXm93NQC+VJJOkaJkqWXXZzrwNGyCvcQ1zDUuuKDj//aHZKjgAiStbIGjig +2XCgpML4sj1QhKkYfo2sY+miGMV6gt0l2I05QUpAXF6ETEeLzou7mUqpJyHYDOBOecW wKsw== X-Gm-Message-State: APjAAAUAsr01lBek52OutgZngkZzT8QwjWxPG/MxL7iY7L0v9T+dfO8m cfgZA+i9rDbSSgqXBNpia9mk3RUews4Cb1yO1vMfIg== X-Google-Smtp-Source: APXvYqx7Exkmbj6LfNvuCBymecwolihDrSf70G2OZntF+krMomgpiFKdfJDix5UcOvaToisC605JRUhBYc1y8FUubvA= X-Received: by 2002:aca:f484:: with SMTP id s126mr255085oih.48.1575914229769; Mon, 09 Dec 2019 09:57:09 -0800 (PST) MIME-Version: 1.0 References: <20191209090306.20433-1-philmd@redhat.com> In-Reply-To: <20191209090306.20433-1-philmd@redhat.com> From: Peter Maydell Date: Mon, 9 Dec 2019 17:56:58 +0000 Message-ID: Subject: Re: [PATCH] hw/arm/virt: Simplify by moving the gic in the machine state To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , Luc Michel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 9 Dec 2019 at 09:03, Philippe Mathieu-Daud=C3=A9 wrote: > > Make the gic a field in the machine state, and instead of filling > an array of qemu_irq and passing it around, directly call > qdev_get_gpio_in() on the gic field. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/arm/virt.h | 1 + > hw/arm/virt.c | 109 +++++++++++++++++++++--------------------- > 2 files changed, 55 insertions(+), 55 deletions(-) > Applied to target-arm.next, thanks. -- PMM