From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.4] disas/arm-a64: Add missing compiler attribute GCC_FMT_ATTR
Date: Sat, 18 Jul 2015 10:13:11 +0100 [thread overview]
Message-ID: <CAFEAcA9UhSNVMQ0KDRmQH6pjo=eYRHC+BACCvdoaSGePFH6asQ@mail.gmail.com> (raw)
In-Reply-To: <1437208027-14584-1-git-send-email-sw@weilnetz.de>
On 18 July 2015 at 09:27, Stefan Weil <sw@weilnetz.de> wrote:
> Type fprintf_function which fits here was defined with this attribute.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This is an optional trivial patch for 2.4 which fixes compiler warnings
> in my build environment (with -Wextra).
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
No objection if you want to put it in 2.4, though I'm a bit
surprised that missing GCC_FMT_ATTR provokes warnings.
The cleanup is nice anyway.
thanks
-- PMM
next prev parent reply other threads:[~2015-07-18 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 8:27 [Qemu-devel] [PATCH for-2.4] disas/arm-a64: Add missing compiler attribute GCC_FMT_ATTR Stefan Weil
2015-07-18 9:13 ` Peter Maydell [this message]
2015-07-20 10:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9UhSNVMQ0KDRmQH6pjo=eYRHC+BACCvdoaSGePFH6asQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).