From: Peter Maydell <peter.maydell@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation
Date: Tue, 29 Aug 2017 10:19:11 +0100 [thread overview]
Message-ID: <CAFEAcA9UzR_HSHxP+mXPPH-ghzruaWW4SzWmDpni0RrdNGc4xw@mail.gmail.com> (raw)
In-Reply-To: <20170826000232.GB29654@flamenco>
On 26 August 2017 at 01:02, Emilio G. Cota <cota@braap.org> wrote:
> An additional "nice to have" would be:
>
> * Allow inlining of TCG code by the instrumenter. Example use case:
> the instrumenter wants to increment a counter every time a
> basic block is executed. Instead of calling a callback function on every block's
> execution, we could just have a translation-time callback to emit at the beginning
> of the translated block the counter increment. This would be much faster, and
> is something that all other tools (e.g. DynamoRIO/Pin) implement.
This is a feature I would strongly prefer us not to implement.
It exposes too much of QEMU's internals (ie TCG) to the
instrumentation, and it would be pretty complicated to use.
thanks
-- PMM
next prev parent reply other threads:[~2017-08-29 9:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:02 [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation Lluís Vilanova
2017-07-24 17:06 ` [Qemu-devel] [PATCH 01/13] instrument: Add documentation Lluís Vilanova
2017-07-24 17:10 ` [Qemu-devel] [PATCH 02/13] instrument: [none] Add null instrumentation mode Lluís Vilanova
2017-07-24 17:14 ` [Qemu-devel] [PATCH 03/13] instrument: [dynamic] Add dynamic " Lluís Vilanova
2017-07-24 17:18 ` [Qemu-devel] [PATCH 04/13] instrument: Allow adding the "instrument" property without modifying event files Lluís Vilanova
2017-07-24 17:22 ` [Qemu-devel] [PATCH 05/13] instrument: [dynamic] Add default public per-event functions Lluís Vilanova
2017-07-24 17:26 ` [Qemu-devel] [PATCH 06/13] instrument: Add event control interface Lluís Vilanova
2017-07-24 17:30 ` [Qemu-devel] [PATCH 07/13] instrument: Add generic command line library loader Lluís Vilanova
2017-07-24 17:34 ` [Qemu-devel] [PATCH 08/13] instrument: [linux-user] Add " Lluís Vilanova
2017-07-24 17:38 ` [Qemu-devel] [PATCH 09/13] instrument: [bsd-user] " Lluís Vilanova
2017-07-24 17:42 ` [Qemu-devel] [PATCH 10/13] instrument: [softmmu] " Lluís Vilanova
2017-07-24 17:46 ` [Qemu-devel] [PATCH 11/13] instrument: [qapi] Add " Lluís Vilanova
2017-07-24 18:03 ` Eric Blake
2017-07-25 8:24 ` Lluís Vilanova
2017-07-25 11:30 ` Eric Blake
2017-07-25 11:51 ` Lluís Vilanova
2017-07-24 17:50 ` [Qemu-devel] [PATCH 12/13] instrument: [hmp] " Lluís Vilanova
2017-07-24 17:54 ` [Qemu-devel] [PATCH 13/13] trace: Rename C++-specific names in event arguments Lluís Vilanova
2017-07-25 13:19 ` [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation Stefan Hajnoczi
2017-07-25 13:30 ` Peter Maydell
2017-07-25 15:11 ` Lluís Vilanova
2017-07-26 11:22 ` Stefan Hajnoczi
2017-07-26 12:44 ` Lluís Vilanova
2017-07-27 10:32 ` Stefan Hajnoczi
2017-07-27 10:40 ` Peter Maydell
2017-07-28 13:42 ` Stefan Hajnoczi
2017-07-28 16:21 ` Lluís Vilanova
2017-08-02 11:04 ` Stefan Hajnoczi
2017-07-26 11:26 ` Stefan Hajnoczi
2017-07-26 11:49 ` Peter Maydell
2017-07-26 12:26 ` Lluís Vilanova
2017-07-27 10:43 ` Daniel P. Berrange
2017-07-27 10:54 ` Peter Maydell
2017-07-27 14:58 ` Lluís Vilanova
2017-07-27 15:21 ` Daniel P. Berrange
2017-07-27 15:33 ` Peter Maydell
2017-07-27 15:45 ` Daniel P. Berrange
2017-07-28 13:34 ` Stefan Hajnoczi
2017-07-28 13:41 ` Peter Maydell
2017-07-28 14:06 ` Daniel P. Berrange
2017-07-28 16:05 ` Lluís Vilanova
2017-08-01 13:48 ` Stefan Hajnoczi
2017-08-01 13:54 ` Peter Maydell
2017-08-02 11:04 ` Stefan Hajnoczi
2017-08-02 11:10 ` Peter Maydell
2017-08-02 14:49 ` Stefan Hajnoczi
2017-08-02 15:19 ` Lluís Vilanova
2017-08-03 11:54 ` Stefan Hajnoczi
2017-08-26 0:14 ` Emilio G. Cota
2017-08-26 0:02 ` Emilio G. Cota
2017-08-29 9:19 ` Peter Maydell [this message]
2017-07-28 13:52 ` Daniel P. Berrange
2017-07-28 16:14 ` Lluís Vilanova
2017-08-01 13:13 ` Stefan Hajnoczi
2017-07-28 15:10 ` Lluís Vilanova
2017-07-27 19:55 ` Lluís Vilanova
2017-07-25 14:47 ` Lluís Vilanova
2017-07-26 11:29 ` Stefan Hajnoczi
2017-07-26 12:31 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9UzR_HSHxP+mXPPH-ghzruaWW4SzWmDpni0RrdNGc4xw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).