From: Peter Maydell <peter.maydell@linaro.org>
To: Jing Huang <jing.huang.pku@gmail.com>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V3 1/3] linux-user: pass sockaddr from host to target
Date: Fri, 20 Jul 2012 19:12:42 +0100 [thread overview]
Message-ID: <CAFEAcA9VY2GUxtPqAfe4XdvM_N0m7tkMLXZivmj36U2jAq3-Aw@mail.gmail.com> (raw)
In-Reply-To: <1342834137-2629-1-git-send-email-jing.huang.pku@gmail.com>
On 21 July 2012 02:28, Jing Huang <jing.huang.pku@gmail.com> wrote:
>
> Signed-off-by: Jing Huang <jing.huang.pku@gmail.com>
When you send v4 of this series please can you include in this
patch the deletion of the comment line
"/* ??? Should this also swap msgh->name? */"
from just above target_to_host_cmsg().
(This patch does the swapping of msgh->name in the caller
and so it has dealt with this ??? question.)
If you make just that change you can add
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
to the commit message for this patch.
-- PMM
prev parent reply other threads:[~2012-07-20 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 1:28 [Qemu-devel] [PATCH V3 1/3] linux-user: pass sockaddr from host to target Jing Huang
2012-07-20 18:12 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9VY2GUxtPqAfe4XdvM_N0m7tkMLXZivmj36U2jAq3-Aw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=jing.huang.pku@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).