From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsHjr-0000JF-2M for qemu-devel@nongnu.org; Fri, 20 Jul 2012 14:18:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsHgx-00033A-A3 for qemu-devel@nongnu.org; Fri, 20 Jul 2012 14:15:42 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:39826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsHgx-00032U-2y for qemu-devel@nongnu.org; Fri, 20 Jul 2012 14:12:43 -0400 Received: by bkcji1 with SMTP id ji1so3189530bkc.4 for ; Fri, 20 Jul 2012 11:12:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1342834137-2629-1-git-send-email-jing.huang.pku@gmail.com> References: <1342834137-2629-1-git-send-email-jing.huang.pku@gmail.com> Date: Fri, 20 Jul 2012 19:12:42 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH V3 1/3] linux-user: pass sockaddr from host to target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jing Huang Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org On 21 July 2012 02:28, Jing Huang wrote: > > Signed-off-by: Jing Huang When you send v4 of this series please can you include in this patch the deletion of the comment line "/* ??? Should this also swap msgh->name? */" from just above target_to_host_cmsg(). (This patch does the swapping of msgh->name in the caller and so it has dealt with this ??? question.) If you make just that change you can add Reviewed-by: Peter Maydell to the commit message for this patch. -- PMM