From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53168)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YfnwE-0007hg-Gb
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:14:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Yfnw9-0001Ri-GF
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:14:30 -0400
Received: from mail-ig0-f182.google.com ([209.85.213.182]:37863)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Yfnw9-0001RV-CJ
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:14:25 -0400
Received: by igblo3 with SMTP id lo3so35211988igb.0
	for <qemu-devel@nongnu.org>; Wed, 08 Apr 2015 04:14:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <55250B42.1070307@redhat.com>
References: <1428437400-8474-1-git-send-email-peter.maydell@linaro.org>
	<1428437400-8474-10-git-send-email-peter.maydell@linaro.org>
	<55250B42.1070307@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 8 Apr 2015 12:14:04 +0100
Message-ID: <CAFEAcA9VbrZ-tQcdUbx9Q8X7vv_-mAKCSsYka_JA4UZJzCSY1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 09/14] exec.c: Capture the memory
 attributes for a watchpoint hit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>

On 8 April 2015 at 12:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 07/04/2015 22:09, Peter Maydell wrote:
>> Capture the memory attributes for the transaction which triggered
>> a watchpoint; this allows CPU specific code to implement features
>> like ARM's "user-mode only WPs also hit for LDRT/STRT accesses
>> made from privileged code".
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Oops, here we are. :)
>
> If you want to move the patch early, and possibly convert
> watch_mem_read/write to use a buffer in the style of subpages, that
> would be great.

Yeah, you got me -- I forgot about watchpoints and then didn't
want to wrestle with moving this patch before the big
coccinelle patch... Just laziness, so I'll shift it.

-- PMM