Re: [Qemu-devel] [PATCH v5 13/21] linux-user: Add signal handling for AArch64

[Peter Maydell <peter.maydell@linaro.org>]

On 1 July 2013 18:35, Peter Maydell <peter.maydell@linaro.org> wrote:
> From: Andreas Schwab <schwab@suse.de>
>
> This patch adds signal handling for AArch64. The code is based on the
> respective source in the Linux kernel.

Couple of minor things I noticed, and will fix for an upcoming v6:

> +typedef struct target_sigaltstack {
> +    abi_ulong ss_sp;
> +    abi_long ss_flags;

The kernel defines this field as 'int', not 'long', so so should we
(would only cause a problem on a big endian host I think,
given the struct layout means ss_size ends up at the same
offset either way.)

> +    abi_ulong ss_size;
> +} target_stack_t;

> +    for (i = 0; i < 32 * 2; i++) {
> +        __put_user(env->vfp.regs[i], &aux->fpsimd.vregs[i]);
> +    }

This is wrong for the (currently hypothetical) case of bigendian
(the other __put_user() are fine because that macro does an
endianness swap if needed, but this is actually an array of
32 int128_t.

-- PMM