From: Peter Maydell <peter.maydell@linaro.org>
To: Gavin Shan <gshan@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, maz@kernel.org,
eric.auger@redhat.com, cohuck@redhat.com,
richard.henderson@linaro.org, zhenyzha@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH v7 0/7] hw/arm/virt: Improve address assignment for high memory regions
Date: Mon, 21 Nov 2022 17:16:46 +0000 [thread overview]
Message-ID: <CAFEAcA9W35dF0L=r2qQppd1FVZ+Di6=3af4qb3T5h2vf8EMsfQ@mail.gmail.com> (raw)
In-Reply-To: <20221029224307.138822-1-gshan@redhat.com>
On Sat, 29 Oct 2022 at 23:43, Gavin Shan <gshan@redhat.com> wrote:
>
> There are three high memory regions, which are VIRT_HIGH_REDIST2,
> VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses
> are floating on highest RAM address. However, they can be disabled
> in several cases.
>
> (1) One specific high memory region is disabled by developer by
> toggling vms->highmem_{redists, ecam, mmio}.
>
> (2) VIRT_HIGH_PCIE_ECAM region is disabled on machine, which is
> 'virt-2.12' or ealier than it.
>
> (3) VIRT_HIGH_PCIE_ECAM region is disabled when firmware is loaded
> on 32-bits system.
>
> (4) One specific high memory region is disabled when it breaks the
> PA space limit.
>
> The current implementation of virt_set_memmap() isn't comprehensive
> because the space for one specific high memory region is always
> reserved from the PA space for case (1), (2) and (3). In the code,
> 'base' and 'vms->highest_gpa' are always increased for those three
> cases. It's unnecessary since the assigned space of the disabled
> high memory region won't be used afterwards.
>
> The series intends to improve the address assignment for these
> high memory regions and introduces new properties for user to
> selectively disable those 3 high memory regions.
I've applied this patchset to a target-arm-for-8.0 branch
that will end up being the target-arm queue once 7.2 is out.
thanks
-- PMM
prev parent reply other threads:[~2022-11-21 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 22:43 [PATCH v7 0/7] hw/arm/virt: Improve address assignment for high memory regions Gavin Shan
2022-10-29 22:43 ` [PATCH v7 1/7] hw/arm/virt: Introduce virt_set_high_memmap() helper Gavin Shan
2022-10-29 22:43 ` [PATCH v7 2/7] hw/arm/virt: Rename variable size to region_size in virt_set_high_memmap() Gavin Shan
2022-10-29 22:43 ` [PATCH v7 3/7] hw/arm/virt: Introduce variable region_base " Gavin Shan
2022-10-29 22:43 ` [PATCH v7 4/7] hw/arm/virt: Introduce virt_get_high_memmap_enabled() helper Gavin Shan
2022-10-29 22:43 ` [PATCH v7 5/7] hw/arm/virt: Improve high memory region address assignment Gavin Shan
2022-10-29 22:43 ` [PATCH v7 6/7] hw/arm/virt: Add 'compact-highmem' property Gavin Shan
2022-10-29 22:43 ` [PATCH v7 7/7] hw/arm/virt: Add properties to disable high memory regions Gavin Shan
2022-11-02 8:57 ` Cornelia Huck
2022-11-03 10:12 ` Eric Auger
2022-11-21 17:16 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9W35dF0L=r2qQppd1FVZ+Di6=3af4qb3T5h2vf8EMsfQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=maz@kernel.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).