Re: [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target

[Peter Maydell <peter.maydell@linaro.org>]

On 11 November 2011 14:53, Chen Wei-Ren (陳韋任) <chenwj@iis.sinica.edu.tw> wrote:
>  Remove libqemu target from Makefile.target.

> diff --git a/Makefile.target b/Makefile.target
> index a111521..d1f7993 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -92,14 +92,6 @@ tci-dis.o: QEMU_CFLAGS += -I$(SRC_PATH)/tcg -I$(SRC_PATH)/tcg/tci
>
>  $(libobj-y): $(GENERATED_HEADERS)
>
> -# libqemu
> -
> -translate.o: translate.c cpu.h
> -
> -translate-all.o: translate-all.c cpu.h
> -
> -tcg/tcg.o: cpu.h
> -

This commit isn't doing what the commit message claims it does.

What you're actually removing is a set of manually inserted
dependencies of some object files on their source files and
on cpu.h. There is already no libqemu target in this makefile.
What you maybe wanted to remove is just the now out of date
comment line?

Now, I think those manually inserted dependencies shouldn't
be there, because the autogenerated .d files already cover
the dependencies they specify as far as I can tell.
But that would be a different commit entirely.)

-- PMM