From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ROsaL-0006Go-2T
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:00:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ROsaI-0006KX-Fb
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:00:04 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:53243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ROsaI-0006K3-9R
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:00:02 -0500
Received: by qadz3 with SMTP id z3so4940246qad.4
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2011 07:00:01 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1321023211-34566-5-git-send-email-chenwj@iis.sinica.edu.tw>
References: <1321023211-34566-1-git-send-email-chenwj@iis.sinica.edu.tw>
	<1321023211-34566-5-git-send-email-chenwj@iis.sinica.edu.tw>
Date: Fri, 11 Nov 2011 15:00:01 +0000
Message-ID: <CAFEAcA9WxThowvgF0HStHzvFciqK5+mEHgruO4byPxQik6B0qw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu
	target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?Q2hlbiBXZWktUmVuICjpmbPpn4vku7sp?= <chenwj@iis.sinica.edu.tw>
Cc: qemu-devel@nongnu.org

On 11 November 2011 14:53, Chen Wei-Ren (=E9=99=B3=E9=9F=8B=E4=BB=BB) <chen=
wj@iis.sinica.edu.tw> wrote:
> =C2=A0Remove libqemu target from Makefile.target.

> diff --git a/Makefile.target b/Makefile.target
> index a111521..d1f7993 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -92,14 +92,6 @@ tci-dis.o: QEMU_CFLAGS +=3D -I$(SRC_PATH)/tcg -I$(SRC_=
PATH)/tcg/tci
>
> =C2=A0$(libobj-y): $(GENERATED_HEADERS)
>
> -# libqemu
> -
> -translate.o: translate.c cpu.h
> -
> -translate-all.o: translate-all.c cpu.h
> -
> -tcg/tcg.o: cpu.h
> -

This commit isn't doing what the commit message claims it does.

What you're actually removing is a set of manually inserted
dependencies of some object files on their source files and
on cpu.h. There is already no libqemu target in this makefile.
What you maybe wanted to remove is just the now out of date
comment line?

Now, I think those manually inserted dependencies shouldn't
be there, because the autogenerated .d files already cover
the dependencies they specify as far as I can tell.
But that would be a different commit entirely.)

-- PMM