From: Peter Maydell <peter.maydell@linaro.org>
To: Octavian Purdila <tavip@google.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com,
eduardo@habkost.net, armbru@redhat.com,
"Phil Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [RFC PATCH] cli: add connect-gpios option
Date: Fri, 18 Oct 2024 16:38:24 +0100 [thread overview]
Message-ID: <CAFEAcA9X1bdtxRL9fm_rnw9ezMZSW6HaURfMsA4aLMSHM4fzdw@mail.gmail.com> (raw)
In-Reply-To: <20241010173929.3910466-1-tavip@google.com>
On Thu, 10 Oct 2024 at 18:39, Octavian Purdila <tavip@google.com> wrote:
>
> From: Valentin Ghita <valentinghita@google.com>
>
> Add option to allow for connecting device GPIOs. This is useful when
> adding a peripheral device from the command line which uses an
> interrupt.
>
> It takes the following options:
>
> * in-dev-path, out-dev-path - required, the device canonical object
> path (e.g. /machine/peripheral-anon/device[0],
> /machine/iotkit/cluster0/armv7m0) for the devices that should have
> their in <-> out GPIOs connected
>
> * in-gpio-name, out-gpio-name - optional, the name of the GPIO list;
> if not specified, the unnamed GPIO list is used
>
> * in-gpio-index, out-gpio-index - optional, the index in the GPIO list
> that identifies the GPIO to be used; if not specified 0 (the first
> GPIO in the list) is used
>
> Usage example:
>
> # add the tmp105 sensor and connects its irq line to the CPU
> qemu-system-arm \
> --machine mps2-an505 \
> --device tmp105,bus=/versatile_i2c/i2c,address=0x50 \
> --connect-gpios out-dev-path=/machine/peripheral-anon/device[0],\
> in-dev-path=/machine/iotkit/cluster0/armv7m0,in-gpio-index=100
This seems to be moving down the path towards "create and
wire up machines on the command line". We shouldn't
be doing that ad-hoc with one small commandline option
at a time, we should be doing it with a coherent plan.
I think Philippe will know the current intentions in this area.
thanks
-- PMM
next prev parent reply other threads:[~2024-10-18 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 17:39 [RFC PATCH] cli: add connect-gpios option Octavian Purdila
2024-10-18 15:38 ` Peter Maydell [this message]
2024-10-18 16:05 ` Daniel P. Berrangé
2024-10-18 16:09 ` Peter Maydell
2024-10-18 18:49 ` Octavian Purdila
2024-10-21 10:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9X1bdtxRL9fm_rnw9ezMZSW6HaURfMsA4aLMSHM4fzdw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tavip@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).