From: Peter Maydell <peter.maydell@linaro.org>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.
Date: Mon, 19 Oct 2015 13:02:41 +0100 [thread overview]
Message-ID: <CAFEAcA9YtY3D+tGVVxtng3PGCe9TKshgh11Zo_QM_9Rvmc597Q@mail.gmail.com> (raw)
In-Reply-To: <20151019115234.GA5874@morn.lan>
On 19 October 2015 at 12:52, Kevin O'Connor <kevin@koconnor.net> wrote:
> On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote:
>> Windows fails to compile:
>> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
>> ‘fw_cfg_dma_mem_read’:
>> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
>> integer constant is too large for ‘long’ type
>
> I don't have a Windows test environment, but I suspect the following:
>
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
>
> should be changed to:
>
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */
Yes. All 64 bit constants should have an LL or ULL suffix.
(The test failure is presumably something different.)
thanks
-- PMM
next prev parent reply other threads:[~2015-10-19 12:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 9:17 [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline Gerd Hoffmann
2015-10-19 9:17 ` [Qemu-devel] [PULL 1/7] fw_cfg: insert string blobs via qemu cmdline Gerd Hoffmann
2015-10-19 9:17 ` [Qemu-devel] [PULL 2/7] fw_cfg: document fw_cfg_modify_iXX() update functions Gerd Hoffmann
2015-10-19 9:18 ` [Qemu-devel] [PULL 3/7] fw_cfg DMA interface documentation Gerd Hoffmann
2015-10-19 9:18 ` [Qemu-devel] [PULL 4/7] Implement fw_cfg DMA interface Gerd Hoffmann
2015-10-19 9:18 ` [Qemu-devel] [PULL 5/7] Enable fw_cfg DMA interface for ARM Gerd Hoffmann
2015-10-19 9:18 ` [Qemu-devel] [PULL 6/7] Enable fw_cfg DMA interface for x86 Gerd Hoffmann
2015-10-19 9:18 ` [Qemu-devel] [PULL 7/7] fw_cfg: Define a static signature to be returned on DMA port reads Gerd Hoffmann
2015-10-19 11:12 ` [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline Peter Maydell
2015-10-19 11:52 ` Kevin O'Connor
2015-10-19 12:02 ` Peter Maydell [this message]
2015-10-19 12:12 ` Kevin O'Connor
2015-10-19 12:22 ` Marc Marí
2015-10-19 13:31 ` Gerd Hoffmann
2015-10-19 13:29 ` Gerd Hoffmann
2015-10-19 13:55 ` Peter Maydell
2015-10-19 15:17 ` Laszlo Ersek
2015-10-19 15:37 ` Marc Marí
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9YtY3D+tGVVxtng3PGCe9TKshgh11Zo_QM_9Rvmc597Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).