From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zo99e-0001V8-Uz
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:03:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zo99Z-0004pE-1D
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:03:06 -0400
Received: from mail-vk0-f43.google.com ([209.85.213.43]:35733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zo99Y-0004oV-UC
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:03:00 -0400
Received: by vkfw189 with SMTP id w189so18356349vkf.2
	for <qemu-devel@nongnu.org>; Mon, 19 Oct 2015 05:03:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20151019115234.GA5874@morn.lan>
References: <1445246284-21137-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA_E-W5zvOmwO1ePFF7O2Y+2vVw-ShF2AtSnh90gSUoQyQ@mail.gmail.com>
	<20151019115234.GA5874@morn.lan>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 19 Oct 2015 13:02:41 +0100
Message-ID: <CAFEAcA9YtY3D+tGVVxtng3PGCe9TKshgh11Zo_QM_9Rvmc597Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface,
 add strings via cmdline.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 19 October 2015 at 12:52, Kevin O'Connor <kevin@koconnor.net> wrote:
> On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote:
>> Windows fails to compile:
>> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
>> =E2=80=98fw_cfg_dma_mem_read=E2=80=99:
>> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
>> integer constant is too large for =E2=80=98long=E2=80=99 type
>
> I don't have a Windows test environment, but I suspect the following:
>
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
>
> should be changed to:
>
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */

Yes. All 64 bit constants should have an LL or ULL suffix.

(The test failure is presumably something different.)

thanks
-- PMM