From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Fix creation of symbolic links for MinGW toolchain
Date: Sat, 17 Mar 2012 17:24:08 +0000 [thread overview]
Message-ID: <CAFEAcA9_P8tmG-M2ytw5eaRPq8KBPc7iXWuGf1M9=rkxnsWRdw@mail.gmail.com> (raw)
In-Reply-To: <4F64B4F2.5020805@weilnetz.de>
On 17 March 2012 15:59, Stefan Weil <sw@weilnetz.de> wrote:
> Am 17.03.2012 16:49, schrieb Peter Maydell:
>> Where do we symlink directories? (I exclude the setting up
>> of the linux headers because that will only happen on Linux
>> hosts where we know we have working symlinks.)
> pc-bios/keymaps
Oh yes, missed that one (since it's a directory name cunningly
hidden in a variable named FILES :-)).
I'm just a little wary of 'rm -rf', especially here where
we're nuking whatever was passed as an argument and we
aren't getting the shell quoting right. In theory we could
use a wildcard for the keymaps the same way we do for a
bunch of the other pc-bios files; I'm not sure if it's worth
the effort, though.
-- PMM
next prev parent reply other threads:[~2012-03-17 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 15:31 [Qemu-devel] [PATCH] configure: Fix creation of symbolic links for MinGW toolchain Stefan Weil
2012-03-17 15:49 ` Peter Maydell
2012-03-17 15:59 ` Stefan Weil
2012-03-17 17:24 ` Peter Maydell [this message]
2012-03-19 11:30 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-03-19 12:20 ` [Qemu-devel] [PATCH v2] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9_P8tmG-M2ytw5eaRPq8KBPc7iXWuGf1M9=rkxnsWRdw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).