From: Peter Maydell <peter.maydell@linaro.org>
To: Boris Figovsky <boris.figovsky@ravellosystems.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] x86: fix daa opcode for al register values higher than 0xf9
Date: Tue, 30 Aug 2011 12:18:35 +0100 [thread overview]
Message-ID: <CAFEAcA9bDrOPybSZX6pYzb8dwJJVymfThcaJSgZhNKG9+4=2OA@mail.gmail.com> (raw)
In-Reply-To: <4e5c8d01.05cbe30a.22c4.ffffe8ac@mx.google.com>
On 30 August 2011 08:00, Boris Figovsky
<boris.figovsky@ravellosystems.com> wrote:
> The second if statement should consider the original al register value,
> and not the new one.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(It took me some time to convince myself that the line
CF <- old_CF or (Carry from AL <- AL + 6)
in the Intel architecture manual is actually redundant; the
AMD docs are much clearer here...)
-- PMM
next prev parent reply other threads:[~2011-08-30 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 7:00 [Qemu-devel] [PATCH] x86: fix daa opcode for al register values higher than 0xf9 Boris Figovsky
2011-08-30 11:18 ` Peter Maydell [this message]
2011-09-02 10:09 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9bDrOPybSZX6pYzb8dwJJVymfThcaJSgZhNKG9+4=2OA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=boris.figovsky@ravellosystems.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).