From: Peter Maydell <peter.maydell@linaro.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>, Li Qiang <liq3ea@163.com>,
Li Qiang <liq3ea@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] e1000e: using bottom half to send packets
Date: Fri, 17 Jul 2020 16:52:32 +0100 [thread overview]
Message-ID: <CAFEAcA9bRhr2hN5nWMQAU7YrfUuGNXCCXNEA0TciOK9o2WAGaw@mail.gmail.com> (raw)
In-Reply-To: <281e3c85-b8eb-0c3e-afc3-41011861b8ea@redhat.com>
On Fri, 17 Jul 2020 at 04:11, Jason Wang <jasowang@redhat.com> wrote:
> I think several things were missed in this patch (take virtio-net as a
> reference), do we need the following things:
>
> - Cancel the bh when VM is stopped.
Similarly, what should we do with the bh when the device
is reset ?
> - A throttle to prevent bh from executing too much timer?
> - A flag to record whether or not this a pending tx (and migrate it?)
thanks
-- PMM
next prev parent reply other threads:[~2020-07-17 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 16:14 [PATCH] e1000e: using bottom half to send packets Li Qiang
2020-07-17 3:10 ` Jason Wang
2020-07-17 4:46 ` Li Qiang
2020-07-17 5:38 ` Jason Wang
2020-07-17 15:46 ` Li Qiang
2020-07-20 3:59 ` Jason Wang
2020-07-20 4:41 ` Li Qiang
2020-07-17 15:52 ` Peter Maydell [this message]
2020-07-20 4:00 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9bRhr2hN5nWMQAU7YrfUuGNXCCXNEA0TciOK9o2WAGaw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).