From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZZyJ-0003cv-QG for qemu-devel@nongnu.org; Thu, 11 Jan 2018 05:20:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZZyJ-0003bu-1j for qemu-devel@nongnu.org; Thu, 11 Jan 2018 05:20:31 -0500 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:34137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZZyI-0003bR-O6 for qemu-devel@nongnu.org; Thu, 11 Jan 2018 05:20:30 -0500 Received: by mail-oi0-x235.google.com with SMTP id a70so1313295oib.1 for ; Thu, 11 Jan 2018 02:20:30 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20180110134846.12940.99993.stgit@pasha-VirtualBox> <029858e0-c6e5-939d-d79e-c7ad7e5069a1@linaro.org> From: Peter Maydell Date: Thu, 11 Jan 2018 10:20:09 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Richard Henderson , Pavel Dovgalyuk , QEMU Developers , maria.klimushenkova@ispras.ru, Pavel Dovgalyuk , "Dr. David Alan Gilbert" , Juan Quintela On 11 January 2018 at 10:15, Paolo Bonzini wrote: > RAM contents are memcpy'd blindly during loadvm. I think that's what > requires a tb_flush. Ah, that makes sense. Could we have a comment documenting the rationale, please? Something like: /* vmload has just updated the content of RAM, bypassing the * usual mechanisms that ensure we flush TBs for writes to * memory we've translated code from. So we must flush all TBs, * which will now be stale. */ thanks -- PMM