From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Christopher Covington <cov@codeaurora.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants
Date: Wed, 3 Jun 2015 15:46:08 +0100 [thread overview]
Message-ID: <CAFEAcA9c_ir6VSGrhmUgpZfydKXE2gBP-CdedysG7kB35m71pg@mail.gmail.com> (raw)
In-Reply-To: <20150603143446.GA24650@aurel32.net>
On 3 June 2015 at 15:34, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2015-06-03 09:09, Aurelien Jarno wrote:
>> On 2015-06-02 19:01, Christopher Covington wrote:
>> > I like using the BIT() macro for this kind of thing.
>>
>> Thanks for the hint, I'll come with an additional patch to fix that in
>> the code.
>
> Unfortunately it doesn't seem as easy as it appears. The BIT() macro uses
> long types
Yeah, I've always taken it as really only being intended for working
with the bitmap functions, on account of the weird choice of "long".
-- PMM
next prev parent reply other threads:[~2015-06-03 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 21:29 [Qemu-devel] [PULL 0/8] SH4 patches for upstream Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants Aurelien Jarno
2015-06-02 23:01 ` Christopher Covington
2015-06-03 7:09 ` Aurelien Jarno
2015-06-03 14:34 ` Aurelien Jarno
2015-06-03 14:46 ` Peter Maydell [this message]
2015-06-01 21:29 ` [Qemu-devel] [PULL 2/8] target-sh4: Split out T from SR Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 3/8] target-sh4: optimize addc using add2 Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 4/8] target-sh4: optimize subc using sub2 Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 5/8] target-sh4: optimize negc using add2 and sub2 Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 6/8] target-sh4: split out Q and M from of SR and optimize div1 Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 7/8] target-sh4: factorize fmov implementation Aurelien Jarno
2015-06-01 21:29 ` [Qemu-devel] [PULL 8/8] target-sh4: remove dead code Aurelien Jarno
2015-06-02 17:23 ` [Qemu-devel] [PULL 0/8] SH4 patches for upstream Peter Maydell
2015-06-02 18:55 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9c_ir6VSGrhmUgpZfydKXE2gBP-CdedysG7kB35m71pg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=cov@codeaurora.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).