From: Peter Maydell <peter.maydell@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: "Shannon Zhao" <zhaoshenglong@huawei.com>,
qemu-arm <qemu-arm@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] ARM: ACPI: Fix use-after-free due to memory realloc
Date: Thu, 31 May 2018 14:42:47 +0100 [thread overview]
Message-ID: <CAFEAcA9dCysLQ6vm9WqB6pdrpiee-kVCgfbqqRy2S1nnpf+4Lg@mail.gmail.com> (raw)
In-Reply-To: <e6827289-812c-eb87-ad52-43094917bb7f@redhat.com>
On 30 May 2018 at 10:03, Auger Eric <eric.auger@redhat.com> wrote:
> Hi Shannon,
>
> On 05/30/2018 09:05 AM, Shannon Zhao wrote:
>> acpi_data_push uses g_array_set_size to resize the memory size. If there
>> is no enough contiguous memory, the address will be changed. So previous
>> pointer could not be used any more. It must update the pointer and use
>> the new one.
>>
>> Also, previous codes wrongly use le32 conversion of iort->node_offset
>> for subsequent computations that will result incorrect value if host is
>> not litlle endian. So use the non-converted one instead.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2018-05-31 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 7:05 [Qemu-devel] [PATCH v3] ARM: ACPI: Fix use-after-free due to memory realloc Shannon Zhao
2018-05-30 9:03 ` Auger Eric
2018-05-31 13:42 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9dCysLQ6vm9WqB6pdrpiee-kVCgfbqqRy2S1nnpf+4Lg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=eric.auger@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).