From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mateusz.krzywicki@windowslive.com"
<mateusz.krzywicki@windowslive.com>
Subject: Re: [Qemu-devel] Possible null-ptr dereference
Date: Mon, 28 Jul 2014 11:01:37 +0100 [thread overview]
Message-ID: <CAFEAcA9dSP_=0UUkQU+gs4dvLT2SE1wOLQphiX6YFuAMca8V-w@mail.gmail.com> (raw)
In-Reply-To: <20140728094926.GE13872@stefanha-thinkpad.redhat.com>
On 28 July 2014 10:49, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Mon, Jul 28, 2014 at 06:03:45AM +0000, Gonglei (Arei) wrote:
>> Hi,
>>
>> Should be easy to fix though. Does the following help?
>>
>> (Cc'ing Stefan & Kevin)
>>
>> -->
>> xen_disk: fix possible null-ptr dereference
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> hw/block/xen_disk.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> This code path can never be reached since protocol is always set to one
> of 3 valid values in xen_disk.c.
Maybe g_assert_not_reached(); ?
thanks
-- PMM
prev parent reply other threads:[~2014-07-28 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 10:52 [Qemu-devel] Possible null-ptr dereference mateusz.krzywicki
2014-07-28 6:03 ` Gonglei (Arei)
2014-07-28 8:20 ` mateusz.krzywicki
2014-07-28 9:49 ` Stefan Hajnoczi
2014-07-28 9:53 ` Gonglei (Arei)
2014-07-28 10:01 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9dSP_=0UUkQU+gs4dvLT2SE1wOLQphiX6YFuAMca8V-w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=kwolf@redhat.com \
--cc=mateusz.krzywicki@windowslive.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).