From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZjAnQ-0003v4-Sf
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 14:47:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZjAnM-0000e8-Sh
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 14:47:36 -0400
Received: from mail-vk0-f43.google.com ([209.85.213.43]:34908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZjAnM-0000e3-OW
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 14:47:32 -0400
Received: by vkao3 with SMTP id o3so102464760vka.2
	for <qemu-devel@nongnu.org>; Mon, 05 Oct 2015 11:47:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20151005181113.GK1260@thinpad.lan.raisama.net>
References: <1441619584-17992-1-git-send-email-pbonzini@redhat.com>
	<1441619584-17992-4-git-send-email-pbonzini@redhat.com>
	<CAFEAcA8BrSmwDB33-TeqEvVP6j7SFu5ENKqQy8tE1Z_9-5VMng@mail.gmail.com>
	<55FAE3A9.5090907@redhat.com>
	<CAFEAcA9xacMPaewoF7K_64G4UhWzM7Lcbas4fu3SgO1CnT1EYA@mail.gmail.com>
	<55FAEB33.50809@redhat.com>
	<CAFEAcA-_u8j6QeDVQwXLf0ydnepFm9iOqfm-3iwkV4myDBzdEQ@mail.gmail.com>
	<20151005181113.GK1260@thinpad.lan.raisama.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 5 Oct 2015 19:47:12 +0100
Message-ID: <CAFEAcA9domdSYJL2icrsVFNjAmxP490dRp5g62ZmTkdKh0LCmg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Andreas Faerber <afaerber@suse.de>

On 5 October 2015 at 19:11, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote:
>> On 17 September 2015 at 17:32, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> >
>> >
>> > On 17/09/2015 18:16, Peter Maydell wrote:
>> >> On 17 September 2015 at 17:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> >>>
>> >>>
>> >>> On 17/09/2015 16:24, Peter Maydell wrote:
>> >>>> Can we revert this one, please? Checkpatch now warns about constructs
>> >>>> like
>> >>>>   typedef struct MyDevice {
>> >>>>       DeviceState parent;
>> >>>>
>> >>>>       int reg0, reg1, reg2;
>> >>>>   } MyDevice;
>>
>> > I think it varies depending on the maintainer.  PPC, USB, SCSI, ACPI all
>> > use a separate typedef.  I'll prepare a revert.
>>
>> Ping on that revert patch? I can't find it onlist...
>
> The x86 pull request I sent today triggers this error, BTW. I hope it
> won't make the pull request be automatically rejected.

Nope, because I don't run checkpatch on pull requests.

-- PMM