Re: [PULL 00/19] Linux user for 5.1 patches

[Peter Maydell <peter.maydell@linaro.org>]

On Fri, 5 Jun 2020 at 12:48, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510:
>
>   Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into s=
> taging (2020-05-26 14:05:53 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-5.1-pull-request
>
> for you to fetch changes up to aa3d2045d4ca760bd8c22935a2d73ee4f3480bd5:
>
>   stubs: Restrict ui/win32-kbd-hook to system-mode (2020-06-05 11:36:00 +0200)
>
> ----------------------------------------------------------------
> linux-user pull request 20200605
>
> Implement F_OFD_ fcntl() command, /proc/cpuinfo for hppa
> Fix socket(), prnctl() error codes, underflow in target_mremap,
>     epoll_create() strace, oldumount for alpha
> User-mode build dependencies improvement
>
> ----------------------------------------------------------------

Hi; this failed to compile on s390 and ppc when building hppa-linux-user:

/home/ubuntu/qemu/linux-user/syscall.c: In function ‘do_openat’:
/home/ubuntu/qemu/linux-user/syscall.c:7484:42: error: ‘is_proc’
undeclared (first use in this function); did you mean ‘
is_error’?
         { "/proc/cpuinfo", open_cpuinfo, is_proc },
                                          ^~~~~~~
                                          is_error
/home/ubuntu/qemu/linux-user/syscall.c:7484:42: note: each undeclared
identifier is reported only once for each function
 it appears in
/home/ubuntu/qemu/rules.mak:69: recipe for target 'linux-user/syscall.o' failed

Looks like this is because the #if condition guarding the
is_proc() definition doesn't line up with the uses (missing
a check on TARGET_HPPA).

thanks
-- PMM