From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEIVw-00050K-9D for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:41:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEIVp-0002uq-RY for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:41:24 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:39602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEIVp-0002sR-K9 for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:41:17 -0400 Received: by mail-la0-f48.google.com with SMTP id gl10so5348823lab.21 for ; Mon, 04 Aug 2014 06:41:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140804092630.GM18947@grmbl.mre> References: <20140804092630.GM18947@grmbl.mre> From: Peter Maydell Date: Mon, 4 Aug 2014 14:40:56 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL] virtio-rng: fix memleak, use error_setg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: John Snow , qemu list On 4 August 2014 10:26, Amit Shah wrote: > Hi, > > This patchset fixes a memleak in virtio-rng init and moves from > error_set to error_setg. > > Please pull. > > The following changes since commit c79805802ba0463713c253307d99ebef56436b8c: > > Open 2.2 development tree (2014-08-01 18:30:08 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git for-2.2 > > for you to fetch changes up to c617dd3b7e8e82511060b8f7a9c51e46c5c1e87a: > > virtio-rng: replace error_set calls with error_setg (2014-08-04 14:50:11 +0530) > > ---------------------------------------------------------------- > John Snow (2): > virtio-rng: Move error-checking forward to prevent memory leak > virtio-rng: replace error_set calls with error_setg > > hw/virtio/virtio-rng.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) Applied, thanks. -- PMM