From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] target/arm: Fix BTI versus CF_PCREL
Date: Thu, 8 Aug 2024 12:38:09 +0100 [thread overview]
Message-ID: <CAFEAcA9h9uD+J0OZ6Vfo63EhSm3WnPwXm6p8fYTC5OC+cS+GPQ@mail.gmail.com> (raw)
In-Reply-To: <20240802003028.795476-1-richard.henderson@linaro.org>
On Fri, 2 Aug 2024 at 01:30, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> With pcrel, we cannot check the guarded page bit at translation
> time, as different mappings of the same physical page may or may
> not have the GP bit set.
>
> Instead, add a couple of helpers to check the page at runtime,
> after all other filters that might obviate the need for the check.
>
> The set_btype_for_br call must be moved after the gen_a64_set_pc
> call to ensure the current pc can still be computed.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> v2: Enable unwind from guarded_page_br.
> Since guarded_page_check is called exclusively with btype != 0,
> it must immediately follow an indirect branch or eret, so cpu
> state is up-to-date, so unwind is not required.
>
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2024-08-08 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 0:30 [PATCH v2] target/arm: Fix BTI versus CF_PCREL Richard Henderson
2024-08-08 11:38 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9h9uD+J0OZ6Vfo63EhSm3WnPwXm6p8fYTC5OC+cS+GPQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).