From: Peter Maydell <peter.maydell@linaro.org>
To: David Hildenbrand <david@redhat.com>
Cc: zhukeqian <zhukeqian1@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Wanghaibin (D)" <wanghaibin.wang@huawei.com>,
yuzenghui <yuzenghui@huawei.com>,
jiangkunkun <jiangkunkun@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>
Subject: Re: 答复: [PATCH v1 1/2] system/cpus: Fix pause_all_vcpus() under concurrent environment
Date: Tue, 19 Mar 2024 14:23:52 +0000 [thread overview]
Message-ID: <CAFEAcA9iBPBvZ-9cFVRdAJaFPZmPK3adn10v2LiS90+1iUzwXA@mail.gmail.com> (raw)
In-Reply-To: <7cc3c19c-00f0-4ad2-b0de-ba42e9b20c2a@redhat.com>
On Tue, 19 Mar 2024 at 09:24, David Hildenbrand <david@redhat.com> wrote:
> I spotted new pause_all_vcpus() / resume_all_vcpus() calls in hw/intc/arm_gicv3_kvm.c and
> thought they would be the problematic bit.
>
> Yeah, that's going to be problematic. Further note that a lot of code does not expect
> that the BQL is suddenly dropped.
Agreed; we already have one nasty set of bugs in the framebuffer
devices because a function drops the BQL briefly:
https://lore.kernel.org/qemu-devel/CAFEAcA9odnPo2LPip295Uztri7JfoVnQbkJ=Wn+k8dQneB_ynQ@mail.gmail.com/T/#u
so let's avoid introducing any more of a similar kind.
Side note, the pause_all_vcpus()/resume_all_vcpus() calls in
hw/i386/vapic.c are probably a bit suspect for similar reasons.
-- PMM
next prev parent reply other threads:[~2024-03-19 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 8:37 [PATCH v1 0/2] Some fixes for pause and resume all vcpus Keqian Zhu via
2024-03-17 8:37 ` [PATCH v1 1/2] system/cpus: Fix pause_all_vcpus() under concurrent environment Keqian Zhu via
2024-03-18 10:10 ` David Hildenbrand
2024-03-19 5:06 ` 答复: " zhukeqian via
2024-03-19 9:24 ` David Hildenbrand
2024-03-19 13:23 ` David Hildenbrand
2024-03-19 14:23 ` Peter Maydell [this message]
2024-03-19 14:46 ` David Hildenbrand
2024-03-19 14:56 ` Peter Maydell
2024-03-17 8:37 ` [PATCH v1 2/2] system/cpus: Fix resume_all_vcpus() under vCPU hotplug condition Keqian Zhu via
2024-03-18 10:14 ` David Hildenbrand
2024-03-19 5:11 ` 答复: " zhukeqian via
2024-03-19 9:25 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9iBPBvZ-9cFVRdAJaFPZmPK3adn10v2LiS90+1iUzwXA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=jiangkunkun@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=qemu-devel@nongnu.org \
--cc=salil.mehta@huawei.com \
--cc=stefanha@redhat.com \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).