From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YOmXZ-0006HH-QD
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:18:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YOmXW-0007cB-9a
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:18:41 -0500
Received: from mail-la0-f50.google.com ([209.85.215.50]:33407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YOmXW-0007c3-28
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:18:38 -0500
Received: by labhz20 with SMTP id hz20so5720654lab.0
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 04:18:36 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <54E5B33D.4000803@redhat.com>
References: <24F20DD4-DD6D-4071-B45F-3CFF81AB419C@gmail.com>
	<54E5B33D.4000803@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 20 Feb 2015 21:18:16 +0900
Message-ID: <CAFEAcA9iPCsuFcJReJkAeZMRQDijP-BqoFWAY2V9VC2fQWqisw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file
	on Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Programmingkid <programmingkidx@gmail.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

On 19 February 2015 at 18:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 18/02/2015 22:09, Programmingkid wrote:
>> +     # Take an image and make the image its own icon:
>> +     sips -i ../pc-bios/qemu-nsis.ico
>> +     # Extract the icon to its own resource file:
>> +     DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc
>
> IIUC sips modifies ../pc-bios/qemu-nsis.ico (adding a resource fork?),
> so it's not possible to put it in Makefile.target.  If "sips" is invoked
> twice by two different recursive invocations of Makefile.target, bad
> things can happen.
>
> I think we can simply distribute tmpicns.rsrc as pc-bios/qemu.rsrc instead.

Why not just use the sips --out option to specify a different
output file? That way we automatically put the current icon
into the executable, and don't have to update a hand-created
qemu.rsrc file in git if we change the icon in future (and I
bet if we don't have the rules for doing this in the makefile
then nobody will remember how to do it).

As a bonus we don't have to keep that file full of ugly high-bit-set
characters in C comments in git :-)

-- PMM