From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TRNOy-0006VV-Id
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:23:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TRNOs-00072v-D1
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:23:12 -0400
Received: from mail-ie0-f173.google.com ([209.85.223.173]:49187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TRNOs-00072p-8O
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:23:06 -0400
Received: by mail-ie0-f173.google.com with SMTP id 17so2262660iea.4
	for <qemu-devel@nongnu.org>; Thu, 25 Oct 2012 06:23:05 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1210251718130.3196@linmac>
References: <1351169867-5466-1-git-send-email-peter.maydell@linaro.org>
	<1351169867-5466-4-git-send-email-peter.maydell@linaro.org>
	<alpine.LNX.2.00.1210251718130.3196@linmac>
Date: Thu, 25 Oct 2012 14:23:05 +0100
Message-ID: <CAFEAcA9j1i6fzFcFuetMzBevCkiPe_aPaY0qREMFoR2sbrOinQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 03/12] hw/pl080: Use LOG_GUEST_ERROR and
	LOG_UNIMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 25 October 2012 14:19, malc <av1474@comtv.ru> wrote:
> On Thu, 25 Oct 2012, Peter Maydell wrote:
>
>> Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error().
>
> It's weird that printing something + abort is replaced by just printing
> a message and the commit message doesn't really reflect the fact.

I assume that the reader knows that hw_error() is fatal;
the point of the series is that these shouldn't be fatal
errors...

-- PMM