From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chHGt-0003WU-8G for qemu-devel@nongnu.org; Fri, 24 Feb 2017 09:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chHGs-00019s-Jv for qemu-devel@nongnu.org; Fri, 24 Feb 2017 09:54:59 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1chHGs-00019Q-Da for qemu-devel@nongnu.org; Fri, 24 Feb 2017 09:54:58 -0500 Received: by mail-wm0-x234.google.com with SMTP id r141so16442681wmg.1 for ; Fri, 24 Feb 2017 06:54:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <8936f97ffdf6fe9a71a300113019bfdba0ecef23.1487522123.git.balaton@eik.bme.hu> References: <8936f97ffdf6fe9a71a300113019bfdba0ecef23.1487522123.git.balaton@eik.bme.hu> From: Peter Maydell Date: Fri, 24 Feb 2017 14:54:36 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 09/10] sm501: Add some more missing registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: QEMU Developers , QEMU Trivial , Aurelien Jarno On 19 February 2017 at 16:35, BALATON Zoltan wrote: > Write only to allow clients to initialise these without failing > > Signed-off-by: BALATON Zoltan What's the point in write-only register values? What does the real hardware do here? If the registers are writes-ignored, there's no need to store the data written into the state struct; if the registers are reads-as-written then implement them that way. (If they get state struct fields the vmstate needs to be updated accordingly, as does reset.) thanks -- PMM