From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default
Date: Tue, 17 Jan 2023 12:22:35 +0000 [thread overview]
Message-ID: <CAFEAcA9n8XSSJRAjGdnNRaZdOjAUCDFQy5NstdEYH642mNCEjA@mail.gmail.com> (raw)
In-Reply-To: <Y8aOVxklkrvriPQc@redhat.com>
On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Jan 17, 2023 at 11:16:32AM +0000, Peter Maydell wrote:
> > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > Something random that looks like bad text data
> > >
> > > ▶ 166/619 /ptimer/oneshot policy=no_immediate_����������������������������������������������������������������...snip....�������������
> >
> > I don't understand this one. The string comes from
> > tests/unit/ptimer-test.c:add_ptimer_tests() but that
> > code creates the test string using g_strlcat() and
> > g_strdup_printf(), so I don't see how it could end
> > up being junk, especially not at that point in
> > the string. I guess it's possible something else in
> > the test is managing to corrupt the g_test test name
> > strings?
>
> Actually it looks like something else spewing ����������
> a to stderr, and this getting intermixed with stdout from the
> test suite. The test case name isn't corrupt, as I see the
> remaining "reload,..." bit that jouins with 'policy=no_immediate_"
>
> Wonder what's responsible for this garbage on stderr...
Mmm.
Also I notice that we could save some output if we can
fix whatever it is that's producing out-of-spec TAP
format and causing this to be printed for every test:
Unknown TAP version. The first line MUST be `TAP version <int>`.
Assuming version 12.
-- PMM
next prev parent reply other threads:[~2023-01-17 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 15:30 [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default Thomas Huth
2023-01-16 13:55 ` Philippe Mathieu-Daudé
2023-01-16 16:55 ` Peter Maydell
2023-01-17 10:23 ` Peter Maydell
2023-01-17 10:32 ` Thomas Huth
2023-01-17 10:44 ` Daniel P. Berrangé
2023-01-17 11:16 ` Peter Maydell
2023-01-17 12:02 ` Daniel P. Berrangé
2023-01-17 12:22 ` Peter Maydell [this message]
2023-01-17 12:26 ` Daniel P. Berrangé
2023-01-18 12:55 ` Thomas Huth
2023-01-18 12:57 ` Daniel P. Berrangé
2023-01-18 13:09 ` float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default) Thomas Huth
2023-01-18 15:51 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9n8XSSJRAjGdnNRaZdOjAUCDFQy5NstdEYH642mNCEjA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).