From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION
Date: Tue, 24 Mar 2026 17:04:45 +0000 [thread overview]
Message-ID: <CAFEAcA9nZ-ROCjRoydZ-uiZRfye4yKjpiORJJbLV9OaTzeOOug@mail.gmail.com> (raw)
In-Reply-To: <acLDpimgjedofUgE@redhat.com>
On Tue, 24 Mar 2026 at 17:02, Daniel P. Berrangé <berrange@redhat.com> wrote:
> Also, is there any better place this can live now that this
> header file has a single #define and nothing else ?
It's used in half a dozen files -- I think that generally
"used by only a few things" is quite a good candidate for
going in its own header, rather than putting it in some
other header that gets pulled in by a lot more C files than
just the half dozen that need it.
-- PMM
next prev parent reply other threads:[~2026-03-24 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:57 [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION Paolo Bonzini
2026-03-24 17:02 ` Daniel P. Berrangé
2026-03-24 17:04 ` Peter Maydell [this message]
2026-03-24 17:11 ` Paolo Bonzini
2026-03-24 17:13 ` Daniel P. Berrangé
2026-03-24 19:18 ` Philippe Mathieu-Daudé
2026-03-25 7:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9nZ-ROCjRoydZ-uiZRfye4yKjpiORJJbLV9OaTzeOOug@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox