From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aldK9-0004Bb-2Z for qemu-devel@nongnu.org; Thu, 31 Mar 2016 10:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aldK7-000279-Qo for qemu-devel@nongnu.org; Thu, 31 Mar 2016 10:11:49 -0400 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:34924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aldK7-00026w-M2 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 10:11:47 -0400 Received: by mail-vk0-x235.google.com with SMTP id e6so104847860vkh.2 for ; Thu, 31 Mar 2016 07:11:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160331125122.GA2636@var.bordeaux.inria.fr> References: <1459416020-19011-1-git-send-email-samuel.thibault@ens-lyon.org> <20160331125122.GA2636@var.bordeaux.inria.fr> From: Peter Maydell Date: Thu, 31 Mar 2016 15:11:27 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: "J. Kiszka" , QEMU Developers On 31 March 2016 at 13:51, Samuel Thibault wrote: > Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote: >> On 31 March 2016 at 10:20, Samuel Thibault wrote: >> > Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) >> > >> > are available in the git repository at: >> > >> > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 >> > >> > for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b= 4: >> > >> > slirp: Add RDNSS advertisement (2016-03-31 11:18:13 +0200) >> > >> > ---------------------------------------------------------------- >> > slirp updates (2) >> > >> > ---------------------------------------------------------------- >> > Samuel Thibault (5): >> > slirp: Allow disabling IPv4 or IPv6 >> > slirp: Split get_dns_addr >> > slirp: Add dns6 resolution >> > slirp: Support link-local DNS addresses >> > slirp: Add RDNSS advertisement >> >> Hi. I'm afraid this doesn't build for Windows: > > Indeed, I forgot to fix the the windows version of the function, could > you try with the attached change? I'm afraid that's not sufficient: /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:53:24: error: =E2=80=98dns6_addr=E2=80=99 defined but not used [-Werror=3Dunused-variable= ] static struct in6_addr dns6_addr; ^ /home/petmay01/linaro/qemu-for-merges/slirp/slirp.c:55:14: error: =E2=80=98dns6_addr_time=E2=80=99 defined but not used [-Werror=3Dunused-var= iable] static u_int dns6_addr_time; ^ cc1: all warnings being treated as errors make: *** [slirp/slirp.o] Error 1 make: *** Waiting for unfinished jobs.... /home/petmay01/linaro/qemu-for-merges/slirp/socket.c: In function =E2=80=98sotranslate_out=E2=80=99: /home/petmay01/linaro/qemu-for-merges/slirp/socket.c:799:17: error: passing argument 2 of =E2=80=98get_dns6_addr=E2=80=99 from incompatible poi= nter type [-Werror] if (get_dns6_addr(&sin6->sin6_addr, &sin6->sin6_scope_id) < 0) { ^ In file included from /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:9= 9:0, from /home/petmay01/linaro/qemu-for-merges/slirp/socket.c:= 10: /home/petmay01/linaro/qemu-for-merges/slirp/libslirp.h:10:5: note: expected =E2=80=98unsigned int *=E2=80=99 but argument is of type =E2=80=98= u_long *=E2=80=99 int get_dns6_addr(struct in6_addr *pdns6_addr, unsigned *scope_id); ^ cc1: all warnings being treated as errors thanks -- PMM