From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZepZc-0007IR-JG for qemu-devel@nongnu.org; Wed, 23 Sep 2015 15:19:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZepZZ-0006Cd-A0 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 15:19:24 -0400 Received: from mail-vk0-f51.google.com ([209.85.213.51]:33188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZepZZ-0006CZ-6t for qemu-devel@nongnu.org; Wed, 23 Sep 2015 15:19:21 -0400 Received: by vkgd64 with SMTP id d64so34329446vkg.0 for ; Wed, 23 Sep 2015 12:19:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1442953507-4074-5-git-send-email-rth@twiddle.net> References: <1442953507-4074-1-git-send-email-rth@twiddle.net> <1442953507-4074-5-git-send-email-rth@twiddle.net> From: Peter Maydell Date: Wed, 23 Sep 2015 12:19:01 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 04/25] target-*: Introduce and use cpu_breakpoint_test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , QEMU Developers , Aurelien Jarno On 22 September 2015 at 13:24, Richard Henderson wrote: > Reduce the boilerplate required for each target. At the same time, > move the test for breakpoint after calling tcg_gen_insn_start. > > Note that arm and aarch64 do not use cpu_breakpoint_test, but still > move the inline test down after tcg_gen_insn_start. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM