qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Tommy Jin <tjin@wavecomp.com>
Cc: Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"pburton.wavecomp.com@gmail.com" <pburton.wavecomp.com@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.
Date: Tue, 2 Apr 2019 07:35:19 +0000	[thread overview]
Message-ID: <CAFEAcA9ooDF8O+LexHnnmVAFsikdo1nhjYafJDYWopN3fva87g@mail.gmail.com> (raw)
In-Reply-To: <MWHPR2201MB11190F1FFDE9CD41E3674DDFB8560@MWHPR2201MB1119.namprd22.prod.outlook.com>

On Tue, 2 Apr 2019 at 14:24, Tommy Jin <tjin@wavecomp.com> wrote:
> For the option2, I think specify the network model in command line is
> not enough, per my understanding, we still need to create the device
> using API like pci_create && qdev_set_nic_properties && qdev_init_nofail,
> otherwise we'll get error prompts like "requested NIC (anonymous, model
> virtio) was not created (not supported by this machine?)", currently I
> just add these pieces of code in /hw/mips/boston.c, Do you call these
> pieces of code board code and what's your suggestion?

If the boston board has PCI support and it is implemented correctly
then you should be able to create a virtio network setup with
command line options like
 -netdev user,id=mynet -device virtio-net-pci,netdev=mynet

(or any other netdev backend, eg tun/tap).

I don't have a boston image/command line to test that with,
but it works for arm boards and should be the same for any
pci capable board model.

thanks
-- PMM

  reply	other threads:[~2019-04-02  7:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01  6:26 [Qemu-devel] Adds virtio_net as the default netcard for mips boston board Tommy Jin
2019-04-01  6:26 ` [Qemu-devel] [PATCH] " Tommy Jin
2019-04-01  9:38   ` Peter Maydell
2019-04-02  2:25     ` Aleksandar Markovic
2019-04-02  2:29       ` Tommy Jin
2019-04-02  2:37         ` Peter Maydell
2019-04-02  7:24           ` Tommy Jin
2019-04-02  7:35             ` Peter Maydell [this message]
2019-04-03  4:52               ` Tommy Jin
2019-04-03  5:03                 ` Peter Maydell
2019-04-02  2:43         ` Aleksandar Markovic
2019-04-02  3:03           ` Tommy Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9ooDF8O+LexHnnmVAFsikdo1nhjYafJDYWopN3fva87g@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aleksandar.m.mail@gmail.com \
    --cc=pburton.wavecomp.com@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tjin@wavecomp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).