From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chf0C-0006e2-0j for qemu-devel@nongnu.org; Sat, 25 Feb 2017 11:15:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chf0B-0002xF-8b for qemu-devel@nongnu.org; Sat, 25 Feb 2017 11:15:20 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1chf0B-0002wZ-2W for qemu-devel@nongnu.org; Sat, 25 Feb 2017 11:15:19 -0500 Received: by mail-wm0-x232.google.com with SMTP id r141so34502754wmg.1 for ; Sat, 25 Feb 2017 08:15:19 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <4bed0ec61e74992657933af970366a9e2636589a.1487522123.git.balaton@eik.bme.hu> From: Peter Maydell Date: Sat, 25 Feb 2017 16:14:57 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 04/10] sm501: Add emulation of chip connected via PCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: QEMU Developers , QEMU Trivial , Aurelien Jarno On 24 February 2017 at 20:25, BALATON Zoltan wrote: > On Fri, 24 Feb 2017, Peter Maydell wrote: >> Dropping the requirement for a base addr is not really the same >> change as adding the PCI device. > > > This is needed for PCI device because the base is not accessible before > something maps the BARs of the device so I had to use something else that is > known. So this change is part of making it a PCI device but I could make > this a separate patch if you think that's better. Should I split it off or > can leave it here? I would split it off. thanks -- PMM