From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsVjA-0008QR-FS
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 05:48:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsVj5-0000hv-Nn
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 05:48:44 -0500
Received: from mail-pb0-f46.google.com ([209.85.160.46]:57233)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsVj5-0000hr-He
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 05:48:39 -0500
Received: by mail-pb0-f46.google.com with SMTP id md12so5330126pbc.33
	for <qemu-devel@nongnu.org>; Mon, 16 Dec 2013 02:48:38 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAOVdOBF-oPxaTXyyBFLq8G3m-eK=-N5EwTWOW=RPsshp4vxtXg@mail.gmail.com>
References: <1386962282-6839-1-git-send-email-peter.maydell@linaro.org>
	<1386962282-6839-6-git-send-email-peter.maydell@linaro.org>
	<CAOVdOBF-oPxaTXyyBFLq8G3m-eK=-N5EwTWOW=RPsshp4vxtXg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 16 Dec 2013 10:48:18 +0000
Message-ID: <CAFEAcA9qGRfsT8mAvnVamjYPzCPPpkgOZ2d6+0GtJ4zoP=3wMg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 5/8] target-arm: A64: add support for
	add, addi, sub, subi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: C Fontana <claudio.fontana@linaro.org>
Cc: Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Will Newton <will.newton@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On 16 December 2013 10:11, C Fontana <claudio.fontana@linaro.org> wrote:
> Sorry for noticing only now,
> but there is a missing return here as well I think:
>
>>  static void disas_add_sub_imm(DisasContext *s, uint32_t insn)

>> +    default:
>> +        unallocated_encoding(s);
>
> should return; here I think.

Yes, fixed.

-- PMM